Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debounce multiple modified events that occur at a same moment #14

Closed
wants to merge 4 commits into from

Conversation

fchastanet
Copy link

Hello,

Thanks for your work
I was having the same problem as described in
#13

I have corrected it with this solution that is not perfect however see comment in it

kind regards

@merofeev
Copy link
Owner

Dear @fchastanet,
Thank you for your contribution. With a heavy heart I have to decline it due to following reasons:

  1. If several files are changed during 2-second interval, all changes except the first one will be lost.
  2. 2-second debounce interval seems too large and it can't be configured by user.
  3. debounce function should be defined in the separate file.

Thank you for understanding.

The version of 1.2.0 docker-windows-volume-watcher has been released. I have added optional debounce support to it (it should not ignore events in different files). To try it:

  1. Update docker-windows-volume-watcher: pip install --upgrade docker-windows-volume-watcher
  2. And run it with debounce option: docker-volume-watcher --debounce 0.1

I kindly ask you to test it in your environment and join discussion of #13 by reporting your results.

@merofeev merofeev closed this Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants